Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translating react dom server #110

Merged
merged 3 commits into from
Feb 7, 2019
Merged

Translating react dom server #110

merged 3 commits into from
Feb 7, 2019

Conversation

devrchancay
Copy link
Contributor

@devrchancay devrchancay commented Feb 6, 2019 •
edited
Loading

Translation of API Reference for ReactDOM

Related: Original issue: Spanish Translation Progress

To Do:

  • Finish first translation draft
  • Check translation
  • Check grammar and orthography
  • Submit final

icarlossz
icarlossz suggested changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@icarlossz icarlossz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks! I left you some comments.

content/docs/reference-react-dom-server.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom-server.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom-server.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom-server.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom-server.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom-server.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom-server.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom-server.md Show resolved Hide resolved
@devrchancay
Copy link
Contributor Author

@icarlossz thanks for the observations.

done!

alejandronanez
alejandronanez approved these changes Feb 7, 2019
View reviewed changes
Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @devrchancay, thanks for your contribution - and congratulations on your first PR!

This is looking good! I'm gonna merge it right away!

Thanks @icarlossz for the review :)

@alejandronanez alejandronanez merged commit 474ac89 into reactjs:master Feb 7, 2019
@tesseralis tesseralis mentioned this pull request Feb 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icarlossz icarlossz icarlossz requested changes

@alejandronanez alejandronanez alejandronanez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devrchancay @alejandronanez @icarlossz